Pack White River - Tools of Citizenship Quests 1.2 & Multiple Languages

[ShoudenKalferas]

5 minutes ago, Rheyner said:

It was unclickable when I was doing my posts T.T
Did some test using this one:
2024-10-02T21:49:10 2.329 INF [MODS]   Trying to load from folder: 'WhiteRiverToC_Bear_Grylls_Claws'
2024-10-02T21:49:10 2.330 INF [MODS]     Loaded Mod: WhiteRiverToC_Bear_Grylls_Claws (1.1.1.0)

 

2024-10-02T19:59:12 7890.346 EXC Value cannot be null.
Parameter name: _value
Parameter name: _value
  at PooledBinaryWriter.Write (System.String _value) [0x00003] in <e8e43063270440388d2e6b7642da1a62>:0 
  at NetPackageGameEventRequest.write (PooledBinaryWriter _bw) [0x00007] in <e8e43063270440388d2e6b7642da1a62>:0 
  at NetConnectionSimple.WriteToStream (System.Int32 streamIndex, System.Int32 packageIndex, System.Int32& packagesToSend, NetPackage& package, PooledBinaryWriter& writer, System.IO.MemoryStream& stream) [0x0007e] in <e8e43063270440388d2e6b7642da1a62>:0 
UnityEngine.StackTraceUtility:ExtractStringFromException(Object)
Log:Exception(Exception)
NetConnectionSimple:WriteToStream(Int32, Int32, Int32&, NetPackage&, PooledBinaryWriter&, MemoryStream&)
NetConnectionSimple:taskSerialize(ThreadInfo)
ThreadManager:myThreadInvoke(Object)
System.Threading.ThreadHelper:ThreadStart_Context(Object)
System.Threading.ExecutionContext:RunInternal(ExecutionContext, ContextCallback, Object, Boolean)
System.Threading.ExecutionContext:Run(ExecutionContext, ContextCallback, Object, Boolean)
System.Threading.ExecutionContext:Run(ExecutionContext, ContextCallback, Object)
System.Threading.ThreadHelper:ThreadStart(Object)

2024-10-02T19:59:12 7890.346 WRN Failed writing first package: NetPackageGameEventRequest of size 30. 3 remaining packages in queue.

I'm honestly having no clue on why I'm having issues now.. Unless it's the New York Map itself causing a problem but that wouldn't effect progression no?

I see an "EXC" log entry... but that's not a WRN or ERR. Is causing the console to popup for your players upon login or is this just some random entries from your server's log?
The one WRN you are showing doesn't seem to reference anything in ToC.

Are you sure the above is causing you an actual problem?

[Rheyner]

14 minutes ago, ShoudenKalferas said:

I see an "EXC" log entry... but that's not a WRN or ERR. Is causing the console to popup for your players upon login or is this just some random entries from your server's log?
The one WRN you are showing doesn't seem to reference anything in ToC.

Are you sure the above is causing you an actual problem?

From what I seen and other players told me is that it would either not allow the completion of the quest or it would let you progress but you couldn't hand it in. But, in the meantime I'll just use admin to give rewards.

It pops up when grabbing steel knuckles/zombie bear bait to complete the current phase in the quest line now that I think about it..

But if I'm the only one having the issue for this quest I'll just put a notice out to let people know to come to me for the quest reward

[ShoudenKalferas]

22 minutes ago, Rheyner said:

From what I seen and other players told me is that it would either not allow the completion of the quest or it would let you progress but you couldn't hand it in. But, in the meantime I'll just use admin to give rewards.

It pops up when grabbing steel knuckles/zombie bear bait to complete the current phase in the quest line now that I think about it..

But if I'm the only one having the issue for this quest I'll just put a notice out to let people know to come to me for the quest reward

I'm not sure what you mean by "grabbing"? The steel knuckles are just vanilla item, so I doubt they would be causing any error. The Zombie bear bait is crafted at a cooking station. How is the bait being grabbed exactly? Are the steps reproducible?

The whole idea behind the release candidates is to work with anyone having problems to try and resolve the issue so that maybe others wont have the same issue. Are you seeing any errors in this quest under 1.1.1.0_rc2? (You've provided me two sets, the first set we concluded was for an old version of code, and the new set didnt seem related)

[Rheyner]

36 minutes ago, ShoudenKalferas said:

I'm not sure what you mean by "grabbing"? The steel knuckles are just vanilla item, so I doubt they would be causing any error. The Zombie bear bait is crafted at a cooking station. How is the bait being grabbed exactly? Are the steps reproducible?

The whole idea behind the release candidates is to work with anyone having problems to try and resolve the issue so that maybe others wont have the same issue. Are you seeing any errors in this quest under 1.1.1.0_rc2? (You've provided me two sets, the first set we concluded was for an old version of code, and the new set didnt seem related)

The new one is from the newest version. I'm currently unable to test more right now as my host provider servers went down as I was making a backup and it corrupted everything. 

[treemt]

18 hours ago, ShoudenKalferas said:

 

Modified the Spirit of Vengeance and Amelia's to use chained-quests to separate the ClearPOI quest from the quest to kill the boss. This seems to fix the multiplayer server issue with rallypoint on both quests.

1.1.1.1_rc2 - This is a release candidate (pre-release) version.

https://github.com/XelaNull/7DTD-WhiteRiver_ToC/archive/refs/tags/WhiteRiverToC-1.1_1.1_rc2.zip

 

Looking forward to your feedback, as in the testing on my own server (with no other modlets installed) it is functioning. As reminder, I am happy to look into any suspected case of modlet conflict, but would just ask that you please point me to the modlet that is conflicting so that I may analyze it and distill the reason for the conflict. The testing that I'm doing at the moment, is on a server with no other modlets installed. I haven't yet worked back up to a heavily modded server.

I am aware that the Bunyan's FireAxe and the burning shaft mod aren't working together at the moment (which I consider a minor thing in comparison to recent reports of some quests being wholly broken or interrupting player progress).

So i'm using that version you just released. I updated amelias quest. In the console i can see this error 

 

Quote

2024-10-03T21:05:42 14673.613 ERR Loading player quests: Quest with ID quest_for_amelias_lost_plans: Failed loading objectives

 

[ShoudenKalferas]

2 hours ago, treemt said:

So i'm using that version you just released. I updated amelias quest. In the console i can see this error 

 

 

Curious if you loaded this up on a new game or an existing save? Is it possible that you already had Amelia quest at time you upgraded?

[treemt]

5 minutes ago, ShoudenKalferas said:

Curious if you loaded this up on a new game or an existing save? Is it possible that you already had Amelia quest at time you upgraded?

Existing save. Most players had already the quest on going. 

This is one of the feedbacks i got from the players

Edited October 3 by treemt (see edit history)

[ShoudenKalferas]

2 minutes ago, treemt said:

Existing save. Most players had already the quest on going. 

This is one of the feedbacks i got from the players

I believe the error you received probably is related to the fact that the quest was changed up notably. I completely removed the last quest and changed the structure of the second to last quest that was causing issue.

However, people reporting that they are still having issues with the rally point is troubling and probably points to some other kind of conflict maybe with another mod. How many other modlets do you have loaded? If the list is short, would you please provide it?

 

I'm a bit baffled people would still be seeing issues with this. The quest code is a near duplicate of the vanilla code for rally point. Are other rally point-based quests working on your server?

Depending on where your players are at in the quest, it might be worth asking them to drop the quest and start it over to see if it makes a difference.

[treemt]

7 minutes ago, ShoudenKalferas said:

I believe the error you received probably is related to the fact that the quest was changed up notably. I completely removed the last quest and changed the structure of the second to last quest that was causing issue.

However, people reporting that they are still having issues with the rally point is troubling and probably points to some other kind of conflict maybe with another mod. How many other modlets do you have loaded? If the list is short, would you please provide it?

 

I'm a bit baffled people would still be seeing issues with this. The quest code is a near duplicate of the vanilla code for rally point. Are other rally point-based quests working on your server?

Depending on where your players are at in the quest, it might be worth asking them to drop the quest and start it over to see if it makes a difference.

The user that i sent the chat has dropped the quest and started over. Also i don't have any other mods which have anything to do with quests. Most of my mods are custom made so it wouldn't help if i gave you the name. How am i going to get rid of that error now? It started since i updated that quest.

[ShoudenKalferas]

9 minutes ago, treemt said:

The user that i sent the chat has dropped the quest and started over. Also i don't have any other mods which have anything to do with quests. Most of my mods are custom made so it wouldn't help if i gave you the name. How am i going to get rid of that error now? It started since i updated that quest.

Okay so on my test instance, I just checked and I have this showing up for a couple different quests. Upon closer inspection of this it appears tied to completed quests that user has completed in the past and still has within their completed quest history. This is likely due to completing the quest with one set of objectives and then later the quest having been coded for a different set of objectives.. hence the error saying that it cant load some of the objectives.

Sadly, the UI doesnt let you remove completed quests even though there is a remove button. I believe the only way to clear the error is to clear the quest history.

You could consider rolling back to previous version of those quests, as another alternative

[treemt]

14 minutes ago, ShoudenKalferas said:

Okay so on my test instance, I just checked and I have this showing up for a couple different quests. Upon closer inspection of this it appears tied to completed quests that user has completed in the past and still has within their completed quest history. This is likely due to completing the quest with one set of objectives and then later the quest having been coded for a different set of objectives.. hence the error saying that it cant load some of the objectives.

Sadly, the UI doesnt let you remove completed quests even though there is a remove button. I believe the only way to clear the error is to clear the quest history.

You could consider rolling back to previous version of those quests, as another alternative

Well i just tried it in single player with no mods except yours. I got this. I don't know whats going on.

[ShoudenKalferas]

2 hours ago, treemt said:

Well i just tried it in single player with no mods except yours. I got this. I don't know whats going on.

Understand that the game was not generally designed to go swapping around modlet versions (Within a gamesave), generally speaking. If there is something wrong in the coding, I'll fix it. But to be sure, you need to test with a new game. If you load a new modlet version up with existing save, maybe it will work and maybe it won't. I do generally strive to write my code so that it is backwards compatible but that is not always possible.

Based on you and Rheyner reporting continued issues with Rally points, I just spent last two hours rewriting the portion of code in this quest to completely remove the rally point altogether. I'll post another release candidate in a bit that contains this change. But please know the same will be true, it's generally recommended to install on a fresh game and if you choose to upgrade on an existing game you should make sure to take backup first and expect that things may not work out perfect.

Some things are in my control as a modlet designer, and some things are not.

Edited October 4 by ShoudenKalferas (see edit history)

[ShoudenKalferas]

Please have a go with this one. I tested it out in a new game locally, which generated no errors and I was able to work Amelia's quest end to end. I then loaded it up on my server, which did show a couple similar EXC messages in the console (but didn't cause the console to open automatically) indicating that the Quest objectives couldn't be loaded. On this (test) server I have completed many quests across variations of modlet verisons so I'm not surprised to see this. I ran through the entire quest end to end and it worked for me and generated no errors. I also have a few extra modlets on my server, but not many.

Hope ya'll see better luck with this third release candidate:
https://github.com/XelaNull/7DTD-WhiteRiver_ToC/archive/refs/tags/WhiteRiverToC-1.1.1.2_rc3.zip

If this works out in your testing, I'll change up Spirit of Vengeance similarly so that the entire pack would be free of rally points.

[ShoudenKalferas]

I suppose no news is good news?

Would appreciate specifically ya'll checking our Spirit of Vengeance. I still haven't touched the rally point code in that one, as no one reported issue specifically with that, that I saw.

 

If no one reports any problems to me by Monday, I'll publish this release candidate

[Seilgrank]

On 10/1/2024 at 6:38 AM, RippedWarrior said:

Bug report: Equipping a burning shaft mod on Bunyans Fire Ax causes a console error and duplicates the burning shaft mod in player inventory. Tested in MP, SP and new world with Toc Mods only.

 

2024-10-01T09:17:55 460.116 INF Time: 7.36m FPS: 59.55 Heap: 2231.0MB Max: 2231.0MB Chunks: 225 CGO: 131 Ply: 1 Zom: 1 Ent: 4 (4) Items: 1 CO: 1 RSS: 4494.8MB
2024-10-01T09:18:06 470.521 WRN [EOS] [LogEOS - Warning] Failed to connect to the backend. ServiceName=[SDKConfig], OperationName=[GetPlatformConfigRoute], Url=[<Redacted>]
2024-10-01T09:18:06 470.620 WRN [EOS] [LogEOS - Warning] SDK Config Platform Update Request Failed, Result Code: EOS_NoConnection, Retrying after 14.432081 seconds
2024-10-01T09:18:07 471.412 ERR [XUi] Error while updating window group 'backpack':
2024-10-01T09:18:07 471.413 EXC Object reference not set to an instance of an object
  at MinEventActionAddPart.Execute (MinEventParams _params) [0x00196] in <6d1a8548522e46dc83d70764cc5f4032>:0 
  at MinEffectGroup.FireEvent (MinEventTypes _eventType, MinEventParams _eventParms) [0x00037] in <6d1a8548522e46dc83d70764cc5f4032>:0 
  at MinEffectController.FireEvent (MinEventTypes _eventType, MinEventParams _eventParms) [0x0001c] in <6d1a8548522e46dc83d70764cc5f4032>:0 
  at ItemValue.FireEvent (MinEventTypes _eventType, MinEventParams _eventParms) [0x0001a] in <6d1a8548522e46dc83d70764cc5f4032>:0 
  at ItemValue.FireEvent (MinEventTypes _eventType, MinEventParams _eventParms) [0x00092] in <6d1a8548522e46dc83d70764cc5f4032>:0 
  at Inventory.updateHoldingItem () [0x00199] in <6d1a8548522e46dc83d70764cc5f4032>:0 
  at Inventory.SetItem (System.Int32 _idx, ItemValue _itemValue, System.Int32 _count, System.Boolean _notifyListeners) [0x00152] in <6d1a8548522e46dc83d70764cc5f4032>:0 
  at Inventory.SetSlots (ItemStack[] _slots, System.Boolean _allowSettingDummySlot) [0x00004] in <6d1a8548522e46dc83d70764cc5f4032>:0 
  at XUiM_PlayerInventory.SetToolbeltItemStacks (ItemStack[] _itemStacks) [0x00000] in <6d1a8548522e46dc83d70764cc5f4032>:0 
  at XUiC_Toolbelt.UpdateBackend (ItemStack[] stackList) [0x00006] in <6d1a8548522e46dc83d70764cc5f4032>:0 
  at XUiC_ItemStackGrid.HandleSlotChangedEvent (System.Int32 slotNumber, ItemStack stack) [0x0001d] in <6d1a8548522e46dc83d70764cc5f4032>:0 
  at XUiC_ItemStack.HandleSlotChangeEvent () [0x0002d] in <6d1a8548522e46dc83d70764cc5f4032>:0 
  at XUiC_ItemStack.set_ItemStack (ItemStack value) [0x0003f] in <6d1a8548522e46dc83d70764cc5f4032>:0 
  at XUiC_ItemStack.ForceSetItemStack (ItemStack _stack) [0x00043] in <6d1a8548522e46dc83d70764cc5f4032>:0 
  at XUiM_AssembleItem.RefreshAssembleItem () [0x00085] in <6d1a8548522e46dc83d70764cc5f4032>:0 
  at XUiM_AssembleItem.AddPartToItem (ItemStack partStack, ItemStack& resultStack) [0x0038e] in <6d1a8548522e46dc83d70764cc5f4032>:0 
  at XUiC_ItemStack.HandleMoveToPreferredLocation () [0x00275] in <6d1a8548522e46dc83d70764cc5f4032>:0 
  at XUiC_ItemStack.Update (System.Single _dt) [0x0021b] in <6d1a8548522e46dc83d70764cc5f4032>:0 
  at XUiController.Update (System.Single _dt) [0x00084] in <6d1a8548522e46dc83d70764cc5f4032>:0 
  at XUiC_Backpack.Update (System.Single _dt) [0x00000] in <6d1a8548522e46dc83d70764cc5f4032>:0 
  at XUiController.Update (System.Single _dt) [0x00084] in <6d1a8548522e46dc83d70764cc5f4032>:0 
  at XUiController.Update (System.Single _dt) [0x00084] in <6d1a8548522e46dc83d70764cc5f4032>:0 
  at XUiController.Update (System.Single _dt) [0x00084] in <6d1a8548522e46dc83d70764cc5f4032>:0 
  at XUi.OnUpdateDeltaTime (System.Single updateDeltaTime) [0x00159] in <6d1a8548522e46dc83d70764cc5f4032>:0 
UnityEngine.StackTraceUtility:ExtractStringFromException(Object)
Log:Exception(Exception)
XUi:OnUpdateDeltaTime(Single)
XUiUpdater:Update()
XUiUpdateHelper:LateUpdate()

It appears that this can be fixed by changing
<property name="FlameEffect" value="ItemModEffects/mod_fireaxe_flamePrefab"/>
to
<property name="FlameEffect" value="@:ItemModEffects/mod_fireaxe_flamePrefab.prefab"/>
which is the same format they use in Vanilla. I'm not sure why this seems to matter for some items and not for others (like Jason's Machete) but it does seem to fix the issue.

[RippedWarrior]

26 minutes ago, Seilgrank said:

It appears that this can be fixed by changing
<property name="FlameEffect" value="ItemModEffects/mod_fireaxe_flamePrefab"/>
to
<property name="FlameEffect" value="@:ItemModEffects/mod_fireaxe_flamePrefab.prefab"/>
which is the same format they use in Vanilla. I'm not sure why this seems to matter for some items and not for others (like Jason's Machete) but it does seem to fix the issue.

Amazing! Thank You

[treemt]

19 hours ago, ShoudenKalferas said:

I suppose no news is good news?

Would appreciate specifically ya'll checking our Spirit of Vengeance. I still haven't touched the rally point code in that one, as no one reported issue specifically with that, that I saw.

 

If no one reports any problems to me by Monday, I'll publish this release candidate

Hey sorry I didn't respond had a lot going on. Thanks for the update I'm going to try it and let you know.

[RippedWarrior]

For the Bear Grylls quests, which require killing bear with Iron Knuckles or Steel Claws, would it possible to make it so Bear Knuckles and Bear Claws (the respective rewards) count for this as well?

Also, 10k xp for crafting Declaration of Citizenship is easily exploited.

 

Thanks!

 

[treemt]

On 10/4/2024 at 2:43 AM, ShoudenKalferas said:

Please have a go with this one. I tested it out in a new game locally, which generated no errors and I was able to work Amelia's quest end to end. I then loaded it up on my server, which did show a couple similar EXC messages in the console (but didn't cause the console to open automatically) indicating that the Quest objectives couldn't be loaded. On this (test) server I have completed many quests across variations of modlet verisons so I'm not surprised to see this. I ran through the entire quest end to end and it worked for me and generated no errors. I also have a few extra modlets on my server, but not many.

Hope ya'll see better luck with this third release candidate:
https://github.com/XelaNull/7DTD-WhiteRiver_ToC/archive/refs/tags/WhiteRiverToC-1.1.1.2_rc3.zip

If this works out in your testing, I'll change up Spirit of Vengeance similarly so that the entire pack would be free of rally points.

Well done mate Amelia's quest is working fine now!

[morggin]

should I wait for this to come out of RC3 status to full release before updating my dedicated server (Linux)?

 

I'm currently running :

7DTD-WhiteRiver_ToC-combined-WhiteRiverToC-combined_1.2

 

UPDATE: disregard, it looks like RC3 is not combined so I'll wait. 

Edited October 6 by morggin (see edit history)

[ShoudenKalferas]

17 hours ago, RippedWarrior said:

For the Bear Grylls quests, which require killing bear with Iron Knuckles or Steel Claws, would it possible to make it so Bear Knuckles and Bear Claws (the respective rewards) count for this as well?

Also, 10k xp for crafting Declaration of Citizenship is easily exploited.

 

Thanks!

 

I'm shocked these values were so high. I don't remember setting them that way previously, but you are right it was set to 10,000xp which is egregious for something you only need a piece of paper to make. I'll do a review of the entire pack's EXP rewards tonight to make sure that no other values are crazy high like this.

Thrilled Amelia's is working, but very keenly interested to know from ya'll if Spirit of Vengeance is still broke.

@morggin Definitely wait. Also, be aware upgrading in our testing wipes player progression. So the next version is going to come with a recommendation of new game.

[treemt]

On 10/3/2024 at 1:09 AM, ShoudenKalferas said:

I appreciate the problem report, but this one is already fixed in 1.1.1.0_rc1! I just ran through the quest end-to-end again and Deschain's functions properly as well (with 1.1.1.0)

Regarding this quest of WhiteRiverToC_Deschains_Revolver mine is still bugged (I have this one https://file.io/2Xx83y3OdBPs ) i cannot update to the new release since it will bug the server. any way it can be edited without having the issue?

[RippedWarrior]

> would it possible to make it so Bear Knuckles and Bear Claws (the respective rewards) count for this as well?

Any thoughts on this?

[BFT2020]

On 10/7/2024 at 8:31 AM, ShoudenKalferas said:

I'm shocked these values were so high. I don't remember setting them that way previously, but you are right it was set to 10,000xp which is egregious for something you only need a piece of paper to make. I'll do a review of the entire pack's EXP rewards tonight to make sure that no other values are crazy high like this.

 

If I was a betting man, I would bet that you set it that high to test it out, then forgot to fix it to your target amount of XP.  I have done that myself in one of my mods.

[ShoudenKalferas]

On 10/7/2024 at 9:54 AM, treemt said:

Regarding this quest of WhiteRiverToC_Deschains_Revolver mine is still bugged (I have this one https://file.io/2Xx83y3OdBPs ) i cannot update to the new release since it will bug the server. any way it can be edited without having the issue?

Imagine this: A player starts "A quest" which has "objective 1" and "objective 2" to complete. But after they complete this quest, the quest code itself is changed to only require "objective 1". The player who started the quest has data saved saying that their quest should have two objectives, but the underlying actual quest now only has one objective in it. There is no way to craft a patch to add "objective 2" back in without also changing the quest for everyone else. This is a simple example of why it isn't always possible to design modlets to be backwards compatible. This is what has happened here as I removed the "rally point" objectives (there were several).

For a long time these quests worked the way they were coded. Literally years went by with them working like this. Because I am aware that substantially changing the quest code causes these situations. This is why I make it a point to try very hard never to touch the objective code on quests already written. In this case, it was unavoidable as rally points on dedicated servers are wholly broken and non-functional for quest code. Removing these objectives appears to be what caused your situation. I'm very sorry for this, but the "bug the server" you talk about is only related to your player's history of past completed quests, which I have no way to change as its baked into the server code itself. The best I could suggest to you if you really dont want to wipe your server is to continue using the same version of the modlet you are currently running. You can still update all the other modlets, as they are independent of one another (except for REQUIRED).

 

Sorry again about this. I do try and make every effort to avoid these situations.

 

On 10/7/2024 at 3:05 PM, RippedWarrior said:

> would it possible to make it so Bear Knuckles and Bear Claws (the respective rewards) count for this as well?

Any thoughts on this?

@RippedWarrior I dont understand what you are trying to say:
"For the Bear Grylls quests, which require killing bear with Iron Knuckles or Steel Claws, would it possible to make it so Bear Knuckles and Bear Claws (the respective rewards) count for this as well?" -- what do you mean "count for this" ? The intention is to prove your worth by killing a bear wearing the knuckles, which rewards you claws and schematic so that you can craft your knuckles once you collect enough claws.

 

On 10/10/2024 at 4:40 PM, BFT2020 said:

 

If I was a betting man, I would bet that you set it that high to test it out, then forgot to fix it to your target amount of XP.  I have done that myself in one of my mods.

@BFT2020 Could be. I'm sure git history would answer this. I found a bunch of similar references across the entire pack to exp rewards above 10k. I've scaled everything back so it is no more than 2k generally. With Deschain's granting 5k per chapter assembly.

 

 

 

I also rewrote Spirit of Vengeance. No one was reporting rally point issue with it, but being that I know that rally points are broke on dedicated servers, I rewrote it to avoid from running into issues with it down the line. Now you have to craft a "Seal of Vengeance" which when cracked open spawns the Juggernaut. I'm running through tests and expect to be able to publish another release candidate later.