Jump to content
  • Problem with the protection of the trader.


    Sarakatunga
    • Version: Alpha 21.1 (B16)

    There is a problem with trader protections. I was creating a custom trader and realized that the game is not sending the proper information to the client. So players can build and destroy trader to their heart's content unless they have custom "trader" prefabs in the MODS folder. It can also happen ej: If you delete trader_rekt from the game folder and enter any server you can destroy that same trader or place claim, blocks etc.

    I do not put the logs because this can be done on all servers (vanilla or not) or private mp game.
     
     
     
     

     

     

     

     

    A21.1_2023-08-24_16-47-12.jpg


    User Feedback

    Recommended Comments

    Summary: Trader not protected if client data is removed.
     

    Game Version: 21.2 (b4)

    OS/Version: Windows 11

    CPU Model: Ryzen 9 3900X

    System Memory: 32 GB

    GPU Model and VRAM: AMD RX 6800 XT 16GB

    Screen Resolution: 2560 x 1440, 144hz

    Video Settings: High/Custom. Not really relevant though.

    Game mode: Client on Dedi, not certain on map, but likely one of the pregens.

     

    Did you wipe old saves? Yes

     

    Did you start a new game? Yes

     

    Did you validate your files? Yes, but then I nuked the trader POI files intentionally.

     

    Are you using any mods? No

     

    EAC on or off? On

     

    Status: NEW

     

    Bug Description: If you delete the local prefab files for traders, you are free to build and destroy on them for the most part. The protected area that the traders exist in seems to still be invulnerable though. 

     

    Detailed steps to reproduce the bug:

    1) Delete trader prefab files from local client.

    2) Join dedi or other mp client.

    3) @%$# around in trader.

     

    Actual result: You are able to build and destroy inside the trader area. I was even able to plop my LCB down in the area. 

     

    Expected result: For the trader to be protected.

    Link to Pastebin Output Log: 
    Mono path[0] = 'D:/Games/SteamGames/steamapps/common/7 Days To Die/7DaysToDie_Da - Pastebin.com

     

    You can see in this image where I have destroyed the deco items and replaced them with my bedroll. I have also knocked out the door on the right side of the room, and placed my LCB.

    20230825172814_1.thumb.jpg.a22ee9a59b5bc96cbc454f25b363cfae.jpg

    Oh, do also note that I was expelled from the trader when it closed. However, I was able to break down part of one of the doors and walk back in for a minute before it kicked me out again.

    Link to comment
    Share on other sites

    just to add my two cents... I'm 99% sure that this is already being exploited.

     

    The bug description sounds exactly like the problems on the TFP public server in july:

    Trader Joel had destroyed terrain inside his compound (e.g. due to explosions), workbenches were placed down, the door to his private rooms was open and more.

    Link to comment
    Share on other sites

    Just want to throw my hat into the ring. It may not be apparent but this issue has huge implications for every single server. When you run a free and public service there are always bad actors who want to spoil it for everyone. Having no ability to properly protect structures from damage be it custom prefabs or vanilla traders means anyone can block/destroy a crucial aspect of the game be it quests you can't get/turn in due to griefing or the ability to engage with the ingame economy. Custom prefabs are also a huge part of the server community, being used as trading hubs, communal horde bases, arenas, teleport portals all of which need to be protected from player damage otherwise anyone can come along and destroy major features on servers. This has been an ongoing issue since the launch of A21 when the old block level protection system was replaced with prefab level and since then it has been causing major problems for servers. 

    It has been the case for years not all prefab files push from the server to the client, now that protection is part of the prefab (and unfortunately a part that doesn't push from the server) all custom prefabs have 0 protect by default unless the client manually installed the prefab files and vanilla trader protection can be defeated as easily as deleting the clients prefab files.

    I won't pretend to understand how any of this works behind the scenes, but if i were asked what would be the solution to this i would point to the a20 block level protection system which didn't require client prefab files be installed and allowed the possibility of defining live areas of a map to be protected fully at will or returned to be unprotected just as easily. I understand there have been many changes to how the world is built and have no idea how feasible function/time to implement that would be.

    This issue will only get worse over time, especially when the story update comes and key quest locations have been maliciously turned into craters to prevent players progressing. I wouldn't expect this issue to be given top level priority but many would be grateful if it was at least given some kind of it will be fixed/addressed/remedied at some point priority.

    I'll create a new 1.0 report and include this info as i believe it's an important issue that needs looked into whenever possible.

    Link to comment
    Share on other sites

    18 hours ago, faatal said:

    Fixed: Trader protection is removed for clients without the POI data (changed clients to receive trader data from server).

     

    Will be in a future update.

    This is great news and to come up with a fix so quickly is amazing. 

     

    Can you share any details on how this will work? 

    Does this mean all prefab data now pushes from the server or just the protection data? 

    Would this fix also work on custom prefabs or just vanilla traders? 

    Link to comment
    Share on other sites

    Any POI set as a trader on the server is added to a list. That list of traders is sent to clients. The clients no longer generate the list from their own files.

     

    POI's xml:

    <property name="TraderArea" value="True" />

    Link to comment
    Share on other sites

    On 6/29/2024 at 3:05 AM, faatal said:

    Any POI set as a trader on the server is added to a list. That list of traders is sent to clients. The clients no longer generate the list from their own files.

     

    POI's xml:

    <property name="TraderArea" value="True" />

    Fantastic, with that working custom poi's should be able to fudge these properties to allow players 24/7 to certain trader protected poi's too?
     

    <property name="TraderAreaTeleportSize" value="a, b, c" />
    <property name="TraderAreaTeleportCenter" value="a, b, c" />

     

    Link to comment
    Share on other sites



    Create an account or sign in to comment

    You need to be a member in order to leave a comment

    Create an account

    Sign up for a new account in our community. It's easy!

    Register a new account

    Sign in

    Already have an account? Sign in here.

    Sign In Now

×
×
  • Create New...