New id system through the console using Class: ClientInfoCollection and Method: GetForNameOrId

Sorry the fix is a bit more complicated than just the switch that I mentioned in the code. You need to check if the parameter contains one of the platform identifiers such as Local_  Steam_  or  XBL_  before running it as a potential id because a player name with an underscore will trigger an error in it. Any improper identifier likely triggers this

This is affecting console commands AI Director Spawn Scouts, Buff Player, Debuff Player, Teleport Player, White List.
Also console commands Admin, Ban, Kick.

Maybe the more important thing is Net Package Game Event Request which is used for the twitch integration I believe. This is using this class and method to grab the Client Info which would cause an error if their name has an underscore in it.

One other thing I noticed is that due to checking the param as a possible player name last, it allows them to mimic another player by using their platform id or crossplatform id as the name. For example, if I changed my steam name to EOS_1a3b5c7a9b1c3a5b7c9a1b3c5a7b9c. I could then pretend to be someone else because it runs the platform id and crossplatform id check before the name check. The name should be checked against first and then the platform id.

In certain circumstances some server managers such as botman, csmm can also be calling on this as a short cut to grab client info but run in to this error if using a player name with an underscore in it.

I have seen some changes in this method with experimental but it did not solve the issue.

I am just going to copy pasta my fix for you.

ClientInfo clientInfo = null;
            int entityId;
            if (int.TryParse(_nameOrId, out entityId))
            {
                clientInfo = SingletonMonoBehaviour<ConnectionManager>.Instance.Clients.ForEntityId(_entityId);
                if (clientInfo != null)
                {
                    return clientInfo;
                }
            }
            clientInfo = SingletonMonoBehaviour<ConnectionManager>.Instance.Clients.GetForPlayerName(_name);
            if (clientInfo != null)
            {
                return clientInfo;
            }
            if (_nameOrId.Contains("Local_") || _nameOrId.Contains("EOS_") || _nameOrId.Contains("Steam_") || _nameOrId.Contains("XBL_") || _nameOrId.Contains("PSN_") || _nameOrId.Contains("EGS_"))
            {
                PlatformUserIdentifierAbs userIdentifier;
                if (PlatformUserIdentifierAbs.TryFromCombinedString(_nameOrId, out userIdentifier))
                {
                    clientInfo = PersistentOperations.GetClientInfoFromUId(userIdentifier);
                    if (clientInfo != null)
                    {
                        return clientInfo;
                    }
                }
            }

Did make a ticket a little while back about the underscore part, I will be looking into the secondary issue mentioned soon.

 

When I checked that out only underscores had any effect on it, and although errors were thrown all the commands ran correctly. If you're having any issues with server manager/other command mods check back with those after it gets fixed and see if they run correctly.

On 12/22/2021 at 11:22 AM, Obsessive Compulsive said:

One other thing I noticed is that due to checking the param as a possible player name last, it allows them to mimic another player by using their platform id or crossplatform id as the name. For example, if I changed my steam name to EOS_1a3b5c7a9b1c3a5b7c9a1b3c5a7b9c. I could then pretend to be someone else because it runs the platform id and crossplatform id check before the name check. The name should be checked against first and then the platform id.

 

Hey, is there anyway you've bypassed Steam's character limit to do that if you tested it? The 32 char limit was hit unless I chopped off EOS_ which did not allow me to impersonate another user