ArgumentNullException when buff from my mod expires

Hi there,

What's the last version this buff worked properly on? I'll need to see if anything changed with how we process buffs between then and now.

Thanks!

Hello,

 

I'm not entirely sure about the last version this buff worked properly on because of the unfortunate timing for me to work on that buff before releasing the mod, and your frequent hotfixes and whatnot. I released the mod on the 21st and you guys pushed 3 patches on that day I believe.

 

I wish I could roll back and test myself to give a more helpful reply, but my best guess is b317 was the last one where it worked correctly.

 

Good luck and keep it up folks!

Looking at my logs, I feel like b325 might have been ok. I can't be 100% sure because I wasn't testing that buff the whole time (and it does not trigger regularly to begin with), but hopefully that helps you narrow things down.

I finally got around to doing some more troubleshooting/testing and I've narrowed down the culprit (as far as the XML is involved):

<triggered_effect trigger="onSelfBuffUpdate" action="RemoveBuff" buff="bb7doi_buffInsomnia">
  <requirement name="CVarCompare" cvar="$bb7doiInsomniaCounter" operation="LTE" value="0"/>
</triggered_effect>
<!-- The following triggers the error with or without requirement child nodes and whether it comes first or last in the effect group-->
<triggered_effect trigger="onSelfBuffRemove" action="ModifyCVar" buff="$bb7doiInsomniaCounter" operation="set" value="0">
  <requirement name="CVarCompare" cvar="$bb7doiInsomniaCounter" operation="NotEquals" value="0"/>
</triggered_effect>

 

This means I've find a workaround for my mod, but I'm sharing this because the underlying issue remains (correct me if I'm wrong but I see no reason why this should break the game).

 

Anyway, I hope that helps.

I must have been too sleepy, ironically. I presume using a buff parameter for trying to set a cvar is what triggered this:

action="ModifyCVar" buff="$bb7doiInsomniaCounter" operation="set" value="0"

... but in my absolutely not vast experience messing up like this while modding this game, normally such minor mistakes result in less catastrophic errors that are handled more gracefully (like null reference exceptions, etc). I hope you folks can improve either the parsing of the XML files or the error handling in the future to avoid this one error at least, because while it might be an edge case (a mistake), its consequences are devastating.

Thanks for coming to my Ted Talk.