DiscipleOfBryan Posted November 14, 2019 Share Posted November 14, 2019 Preamble: Salutations! This is not only my first modlet here, but also my first post. The short version goes a little something like this: I love the game, only recently got it and I can see a lot of potential in it and am thoroughly enjoying getting used to the mechanics. Great work, TFP. Only a few days after I got in on the fun, A18.1 b7/8 is released – imagine my shock when I saw this: Mining iron ore yields [scrap] iron I don't mean to come across as indignant, but what the? I had no intention of getting into modding for this as I'm quite keen to see where TFP takes things themselves, given how much I enjoy the game so far. This change, however, is just nonsensical from my point of view. The previous workflow for iron was perfectly logical and balanced: Mine raw iron ore -> smelt in forge -> process into forged iron bars or scrap iron as needed. As an aside, scrap iron is already incredibly abundant in the game. So, I quickly got acquainted with xpath and slapped together this mod which intends to maintain the above logical workflow in the event that the resourceIronFragment item is completely removed from the game. __________________________________________________ Logical Iron Mining GitHub/Download: https://github.com/DiscipleOfBryan/7dtd_logical_iron_mining Completed Features: Reverts terrIronOre block behavior to give resourceIronFragment on Harvest.Reverts oreIronBoulder block behavior to give resourceIronFragment on Harvest. To Do: Reproduce resourceIronFragment item as is/was, in the event that it is removed from the game and pending further study of xpath. Link to comment Share on other sites More sharing options...
War3zuk Posted November 14, 2019 Share Posted November 14, 2019 Haha was talking to my misses about this last night.. I asked what she would change in game & thats exactly what she said only with more swearing lol Link to comment Share on other sites More sharing options...
DiscipleOfBryan Posted November 14, 2019 Author Share Posted November 14, 2019 ~thats exactly what she said only with more swearing lol You should have heard me on discord... Link to comment Share on other sites More sharing options...
War3zuk Posted November 14, 2019 Share Posted November 14, 2019 I can imagine as shes so Delicate normally .. But proper looses it when TFP seem to make stupid choices... Link to comment Share on other sites More sharing options...
vampirecosmonaut Posted November 14, 2019 Share Posted November 14, 2019 Scrap Iron is available from so many sources. Removing the ore makes very little sense. I looked at the old blocks.xml and I think this reverses it exactly: <configs> <set xpath="/blocks/block[@name='terrOreIron']/drop[@event='Harvest' and @name='resourceScrapIron']/@count">21</set> <set xpath="/blocks/block[@name='terrOreIron']/drop[@event='Harvest' and @name='resourceScrapIron']/@name">resourceIronFragment</set> <set xpath="/blocks/block[@name='oreIronBoulder']/drop[@event='Harvest' and @name='resourceScrapIron']/@count">21</set> <set xpath="/blocks/block[@name='oreIronBoulder']/drop[@event='Harvest' and @name='resourceScrapIron']/@name">resourceIronFragment</set> </configs> Link to comment Share on other sites More sharing options...
DiscipleOfBryan Posted November 14, 2019 Author Share Posted November 14, 2019 Scrap Iron is available from so many sources. Removing the ore makes very little sense. I looked at the old blocks.xml and I think this reverses it exactly: <configs> <set xpath="/blocks/block[@name='terrOreIron']/drop[@event='Harvest' and @name='resourceScrapIron']/@count">21</set> <set xpath="/blocks/block[@name='terrOreIron']/drop[@event='Harvest' and @name='resourceScrapIron']/@name">resourceIronFragment</set> <set xpath="/blocks/block[@name='oreIronBoulder']/drop[@event='Harvest' and @name='resourceScrapIron']/@count">21</set> <set xpath="/blocks/block[@name='oreIronBoulder']/drop[@event='Harvest' and @name='resourceScrapIron']/@name">resourceIronFragment</set> </configs> Excellent! Thanks for providing the actual numbers too, wasn't sure if 50 was correct (it seemed in line with other mined resources). I'll fix it up so that it also affects the surface boulders. I totally forgot about them. Link to comment Share on other sites More sharing options...
vampirecosmonaut Posted November 14, 2019 Share Posted November 14, 2019 No worries. Happy to help. Link to comment Share on other sites More sharing options...
DiscipleOfBryan Posted November 14, 2019 Author Share Posted November 14, 2019 No worries. Happy to help. Definitely appreciate it. On the subject of help, is there any insight you can offer here? Link to comment Share on other sites More sharing options...
DiscipleOfBryan Posted November 14, 2019 Author Share Posted November 14, 2019 Mod updated on GitHub with changes provided by vampirecosmonaut. Link to comment Share on other sites More sharing options...
vampirecosmonaut Posted November 15, 2019 Share Posted November 15, 2019 Definitely appreciate it. On the subject of help, is there any insight you can offer here? Ah, it looks like you figured it out. I had actually gone to bed for once. Link to comment Share on other sites More sharing options...
DiscipleOfBryan Posted November 15, 2019 Author Share Posted November 15, 2019 Haha, yeah somewhat. Needs further testing with a fresh game or something. Shelved for now while I confirm if crafting the item at least works lol. Link to comment Share on other sites More sharing options...
-Holo- Posted November 15, 2019 Share Posted November 15, 2019 Nice work! this was one of the WTF moments I had when first started up A18! There's a limit to how much one should abstract-icide a game. (abstracide? abstractify? abstactra-kadavra?) \o/ Gonna go see if I can mod out the ability to scrap rawiron. Link to comment Share on other sites More sharing options...
DiscipleOfBryan Posted November 15, 2019 Author Share Posted November 15, 2019 Gonna go see if I can mod out the ability to scrap rawiron. I'm only just now finding out you can do that... (relatively new player) Gonna include that in this mod too if either one of us can achieve it. EDIT: Upon further inspection, it doesn't appear to be possible via the .xml files. Also, having thought it over, I'm not too fussed about the raw iron being scrapable, as the current amount of ScrapIron yielded via that method is less than what you get per unit smelted in a forge (if I'm not mistaken). Link to comment Share on other sites More sharing options...
-Holo- Posted November 18, 2019 Share Posted November 18, 2019 I'm only just now finding out you can do that... (relatively new player) Gonna include that in this mod too if either one of us can achieve it. EDIT: Upon further inspection, it doesn't appear to be possible via the .xml files. Also, having thought it over, I'm not too fussed about the raw iron being scrapable, as the current amount of ScrapIron yielded via that method is less than what you get per unit smelted in a forge (if I'm not mistaken). I think it -might- be doable by altering the material settings for rawiron, if memory serves thats what defines what it can be scrapped into. But that might muck up something else, need to test when I have the time for A18. Have been busy playing A15 Link to comment Share on other sites More sharing options...
Gazz Posted November 18, 2019 Share Posted November 18, 2019 Gonna go see if I can mod out the ability to scrap rawiron. It is possible. Look at glass/sand. Link to comment Share on other sites More sharing options...
DiscipleOfBryan Posted November 19, 2019 Author Share Posted November 19, 2019 It is possible. Look at glass/sand. Bingo. <property name="NoScrapping" value="true"/> Link to comment Share on other sites More sharing options...
-Holo- Posted November 20, 2019 Share Posted November 20, 2019 It is possible. Look at glass/sand. That was unexpectedly easy! thanks Link to comment Share on other sites More sharing options...
Recommended Posts
Archived
This topic is now archived and is closed to further replies.