Jump to content
  • Quest reward parsing from XML broken for groupQuestT1SkillMagazineBundle

    • Version: A21 B317


    Summary: It seems that the groupQuestT1SkillMagazineBundle Item in quest rewards is causing issues with the reward level of subsequent rewards.


    Game Version: (A21 B317)

    OS/Version: Windows

    CPU Model: x

    System Memory: 32 GB

    GPU Model and VRAM:

    Screen Resolution: 1920x1080

    Video Settings:

    Game mode: SP


    Did you wipe old saves? Yes


    Did you start a new game? Yes


    Did you validate your files? Yes


    Are you using any mods? Yes


    EAC on or off? off


    Status: NEW


    Bug Description:

    When investigating the drop in quest rewards quality after the B317 patch and hearing multiple other people complain about the same issue I stumbled upon the groupQuestT1SkillMagazineBundle as the likely culprit.

    If the groupQuestT1SkillMagazineBundle is the first reward in a quests reward list and the reward is NOT chosen on the first iteration of the reward list, all subsequent rewards lose their "value" property. Should the bundle be chosen as a reward then the following rewards keep their value property on the first iteration of the list. Should the quest fail to generate 5 rewards and iterate over the list again all subsequent rewards will also lose their value (unclear if that part is intended).

    In the previous patch this problem did not occur since the bundle was fixed and always chosen as a reward option.


    A workaround that we discovered was moving the groupQuestT1SkillMagazineBundle down in each quests reward list to just above the steel reward. In this case the first iteration of the list would always produce expected results.


    Detailed steps to reproduce the bug:

    In a fresh world I tested multiple variations of the original quests.xml.

    With "givequest tier6_test_turnin" I gave myself the test quest and turned that in at the trade.


    Actual result:

    Rewards skew to being similar to T1 quest rewards UNLESS you get the skillbookbundle, in which case the rewards match the expected quality for the loot table from the quests.xml.

    Rewards include items that shouldn't be possible with the given values in the quests.xml (like iron knuckles).

    Here another player logged a bunch of results of the T6 test quest. https://imgur.com/a/8cqiCcX


    Expected result: (what you expect to occur)

    Rewards should match the values given in the quests.xml.

    User Feedback

    Recommended Comments

    Found and fixed the root cause of this issue in code, but also reworked some of the xml issues.
    Rewards are looking MUCH better now.

    Thanks for the report!

    Link to comment
    Share on other sites

    And that fix will be 

    19 hours ago, schwanz9000 said:

    Found and fixed the root cause of this issue in code, but also reworked some of the xml issues.
    Rewards are looking MUCH better now.

    Thanks for the report!

    And Im assuming that fix will be in the next experimental release? Just wanted to confirm.

    Link to comment
    Share on other sites

    Create an account or sign in to comment

    You need to be a member in order to leave a comment

    Create an account

    Sign up for a new account in our community. It's easy!

    Register a new account

    Sign in

    Already have an account? Sign in here.

    Sign In Now

  • Create New...